← Back to team overview

zeitgeist team mailing list archive

Re: [Bug 620109] Re: Refuses to log events without subjects

 

On 19 August 2010 18:42, Markus Korn <thekorn@xxxxxx> wrote:
> As I mentioned already on IRC, although I don't like the idea of having events without a subject (because it's conceptual: "something is happening, but we don't know what") I think this is the easiest solution for the usecase of a GIO dataprovider which sits in the middle of the application which launches another app and the new app itself.
> And I also think that this solution is kind of abusing the actor field, I mean it's not the app which is about to be launched which is doing something when the event is triggered.
>
> But the most important concern was raised by mhr3 on IRC: the fact that
> events can have no subjects will most likely break some clients, because
> until now the client can assume that each event has at least one
> subject.
>
> I would *really* like to take some time to discuss a more suitable
> solution, but I understand that we might need to make some compromises
> if we want to have such AppInfo.launch() dataprovider soonish

Ok. I tend to agree. Another factor is also that a specific "app
launched" event also fits better in a semantic world where we share
data with Tracker.

>From a technical POV it is however not possible to write a generic DP
by using a GIO extension point hook for AppInfo.launch(). As I also
mentioned on IRC the extension point code has no way of knowing which
app it's running inside. Michal mentioned that we could use getpid()
-> bamfdaemon to look up the .desktop file for the app we run inside,
but I am not very happy about that prospect.

As the GApplication/GtkApplication APIs are still in the making we may
be able to influence them so that you pass the desktop id of your app
in the constructor. I'll talk to the G/Gtk guys about this...

-- 
Refuses to log events without subjects
https://bugs.launchpad.net/bugs/620109
You received this bug notification because you are a member of Zeitgeist
Framework Team, which is subscribed to Zeitgeist Framework.

Status in Zeitgeist Framework: New

Bug description:
Zeitgeist says:

Traceback (most recent call last):
  File "/usr/share/zeitgeist/_zeitgeist/engine/main.py", line 497, in _insert_event_without_error
    return self._insert_event(event, sender)
  File "/usr/share/zeitgeist/_zeitgeist/engine/main.py", line 508, in _insert_event
    raise ValueError("Illegal event format: No subject")
ValueError: Illegal event format: No subject

If I send it an event without a subject. The reason why I am doing that is because I am trying to log whenever an app is launched. Like for instance when I launch the Gnome calculator. This way I can have "most popular apps" listings and what not :-)

So my request: Can we lax the requirement for events to have a subject?





References