← Back to team overview

zeitgeist team mailing list archive

Thread
Date

Re: [Merge] lp:~zeitgeist/zeitgeist/datasource-properties-fix into lp:zeitgeist

To: mp+33775@xxxxxxxxxxxxxxxxxx
From: Mikkel Kamstrup Erlandsen <mikkel.kamstrup@xxxxxxxxx>
Date: Mon, 30 Aug 2010 18:38:42 -0000
In-reply-to: <20100826130844.31945.32241.launchpad@loganberry.canonical.com>
Reply-to: mp+33775@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Approve
Looks good. I didn't actually run the unit tests but the diff is clean enough that I don't think regressions are a big danger here.

Nice work!
-- 
https://code.launchpad.net/~zeitgeist/zeitgeist/datasource-properties-fix/+merge/33775
Your team Zeitgeist Framework Team is subscribed to branch lp:~zeitgeist/zeitgeist/datasource-properties-fix.

References

[Merge] lp:~zeitgeist/zeitgeist/datasource-properties-fix into lp:zeitgeist
From: Seif Lotfy, 2010-08-26