zeitgeist team mailing list archive

Thread
Date

Re: [Merge] lp:~seif/zeitgeist/clean-up-get-events into lp:zeitgeist

To: mp+40529@xxxxxxxxxxxxxxxxxx
From: Mikkel Kamstrup Erlandsen <mikkel.kamstrup@xxxxxxxxx>
Date: Wed, 10 Nov 2010 12:47:02 -0000
In-reply-to: <20101110121617.2914.99055.launchpad@loganberry.canonical.com>
Reply-to: mp+40529@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Something looks to be ascrew if an event has multiple subject? But it looks like that was also the case before this branch..? Do we have a test for this?

Can you re-insert the comment about returning None for missing events - I think it's nice to note there that it is our API contract.

But looks good to me otherwise
-- 
https://code.launchpad.net/~seif/zeitgeist/clean-up-get-events/+merge/40529
Your team Zeitgeist Framework Team is requested to review the proposed merge of lp:~seif/zeitgeist/clean-up-get-events into lp:zeitgeist.

References

[Merge] lp:~seif/zeitgeist/clean-up-get-events into lp:zeitgeist
From: Seif Lotfy, 2010-11-10