zeitgeist team mailing list archive

[Launchpad Bug Tracker <673922@xxxxxxxxxxxxxxxxxx>]

** Branch linked: lp:zeitgeist

-- 
ZeitgeistEngine.get_events(rows=x) is broken
https://bugs.launchpad.net/bugs/673922
You received this bug notification because you are a member of Zeitgeist
Framework Team, which is subscribed to Zeitgeist Framework.

Status in Zeitgeist Framework: Fix Committed

Bug description:
If one hands over a list of rows instead of ids to the method, get_events will fail with a TypeError. The reason is simple: ids will become a generator (line 174) and in line 183 there is a len(ids) call, which is undefined for generators.
This can be solved by either fixing the code, or removing the rows argument, as a short grep through the zeitgeist source and testsuite shows that we are not using this argument at all.