← Back to team overview

zeitgeist team mailing list archive

Re: [Merge] lp:~manishsinha/zeitgeist/fix-691167 into lp:zeitgeist

 

kill zeitgeist-daemon then
run tests/blacklist-test.py
it does not fail :P

On Thu, Dec 16, 2010 at 7:49 PM, Manish Sinha <manishsinha@xxxxxxxxxx>wrote:

> Manish Sinha has proposed merging lp:~manishsinha/zeitgeist/fix-691167 into
> lp:zeitgeist.
>
> Requested reviews:
>  Zeitgeist Framework Team (zeitgeist)
> Related bugs:
>  #691167 The payload is sometimes mentioned as string and sometimes as
> array of bytes
>  https://bugs.launchpad.net/bugs/691167
>
>
> Fixed the Event repr from dbus.Array to basic python list instead of string
>
> P.S.: 4 tests for blacklist is failing. Never mind it is going to be fixed
> sooner since bug #612344 is open and in progress
>
> --
> https://code.launchpad.net/~manishsinha/zeitgeist/fix-691167/+merge/43948
> You are subscribed to branch lp:zeitgeist.
>
> === modified file '_zeitgeist/engine/datamodel.py'
> --- _zeitgeist/engine/datamodel.py      2010-01-23 19:20:41 +0000
> +++ _zeitgeist/engine/datamodel.py      2010-12-16 18:49:09 +0000
> @@ -55,7 +55,7 @@
>                popo = []
>                popo.append(map(unicode, ev[0]))
>                popo.append([map(unicode, subj) for subj in ev[1]])
> -               popo.append(str(ev[2]))
> +               popo.append([p for p in ev[2]])
>                return popo
>
>  class Subject(OrigSubject):
>
>
>


-- 
This is me doing some advertisement for my blog http://seilo.geekyogre.com

https://code.launchpad.net/~manishsinha/zeitgeist/fix-691167/+merge/43948
Your team Zeitgeist Framework Team is requested to review the proposed merge of lp:~manishsinha/zeitgeist/fix-691167 into lp:zeitgeist.



References