zeitgeist team mailing list archive

[Seif Lotfy <seif@xxxxxxxxx>]

The proposal to merge lp:~seif/zeitgeist/fix-738555 into lp:zeitgeist has been updated.

Description changed to:

Add a try except block in the _write_to_disk method
Add a counter to write to disk upon every 20 events
Fixed some indents
----
OK so a primary solution for this was putting the content of _write_to_disk
in datasource_registery.py in a normal " try - catch " block
My primary fear was that the next extension or zeitgeist would crash trying
to write to the disk. This was not the case and the error was caught.
To explain why the other stuff did not crash is:
1) This was the only extension writing to disk upon unloading
2) The engine does not write to disk upon exit since all events are written
to disk upon entrance.
My primary solution would be to put the _write_to_disk in a normal "try -
catch" block for now...

For more details, see:
https://code.launchpad.net/~seif/zeitgeist/fix-738555/+merge/58818
-- 
https://code.launchpad.net/~seif/zeitgeist/fix-738555/+merge/58818
Your team Zeitgeist Framework Team is requested to review the proposed merge of lp:~seif/zeitgeist/fix-738555 into lp:zeitgeist.