zeitgeist team mailing list archive

[Manish Sinha (मनीष सिन्हा) <manishsinha@xxxxxxxxxx>]

Manish Sinha (मनीष सिन्हा) has proposed merging lp:~manishsinha/zeitgeist/fix-744818-fix-daemon-crash-on-replace-missing into lp:zeitgeist.

Requested reviews:
  Zeitgeist Framework Team (zeitgeist)
Related bugs:
  Bug #744818 in Zeitgeist Framework: "Don't crash on daemon start if a running zeitgeist daemon instance is found"
  https://bugs.launchpad.net/zeitgeist/+bug/744818

For more details, see:
https://code.launchpad.net/~manishsinha/zeitgeist/fix-744818-fix-daemon-crash-on-replace-missing/+merge/58886

Fixes bug #744818 in which the user is not showed the RuntimeError when --replace is not used when started a new instance of the daemon

The fix was made by replacing logging.exception to logging.info
-- 
https://code.launchpad.net/~manishsinha/zeitgeist/fix-744818-fix-daemon-crash-on-replace-missing/+merge/58886
Your team Zeitgeist Framework Team is requested to review the proposed merge of lp:~manishsinha/zeitgeist/fix-744818-fix-daemon-crash-on-replace-missing into lp:zeitgeist.

=== modified file 'zeitgeist-daemon.py'
--- zeitgeist-daemon.py	2011-04-14 07:29:21 +0000
+++ zeitgeist-daemon.py	2011-04-24 00:46:23 +0000
@@ -164,7 +164,8 @@
 	try:
 		mainloop, interface = setup_interface()
 	except RuntimeError, e:
-		logging.exception("Failed to setup the RemoteInterface")
+		logging.info("Failed to setup the RemoteInterface")
+		logging.info(e.message)
 		sys.exit(1)
 	
 	if _config.options.start_datahub: