← Back to team overview

zeitgeist team mailing list archive

[Bug 772041] Re: Timestamp isn't considered when choosing events by popularity

 

I'm attaching an initial try at fixing this. The patch fixes all test
cases, but I still need to clean it up somehow before it can be merged.

** Patch added: "initial_patch.diff"
   https://bugs.launchpad.net/zeitgeist/+bug/772041/+attachment/2096985/+files/initial_patch.diff

-- 
You received this bug notification because you are a member of Zeitgeist
Framework Team, which is subscribed to Zeitgeist Framework.
https://bugs.launchpad.net/bugs/772041

Title:
  Timestamp isn't considered when choosing events by popularity

Status in Zeitgeist Framework:
  New

Bug description:
  Currently the MostPopular* and LeastPopular* methods are choosing a
  random (*) event from within all events matching the criteria.

  Is this desired? I believe it'd make more sense to return that one
  with the highest timestamp for MostPopular* and the one with the
  oldest timestamp for LeastPopular*, or something along that lines
  (there are currently such "timestamp ASC/DESC" statements in the code,
  but they aren't working, so if we agree on this property they need to
  be fixed).

  (* Actually, it's the last one which was inserted into the database,
  but that doesn't mean anything.)


References