← Back to team overview

zeitgeist team mailing list archive

Re: [Merge] lp:~zeitgeist/zeitgeist/some-fixes into lp:~zeitgeist/zeitgeist/bluebird

 

Review: Needs Fixing

[Merge line numbers as here on LP]

[15,29]: I don't like those methods being public in datamodel, it's an implementation detail.
[190,221,247,256]: Missing space before '('
[238]: It doesn't seem to be fixed. :P

Not really sure what to do about the first one, I'd rather have it inside Engine (public static) for the time being.
-- 
https://code.launchpad.net/~zeitgeist/zeitgeist/some-fixes/+merge/74927
Your team Zeitgeist Framework Team is subscribed to branch lp:~zeitgeist/zeitgeist/bluebird.


References