zeitgeist team mailing list archive

[noreply@xxxxxxxxxxxxx]

------------------------------------------------------------
revno: 243
committer: Seif Lotfy <seif@xxxxxxxxx>
branch nick: bluebird
timestamp: Fri 2011-09-16 00:15:58 +0200
message:
  remove fixed FIXMEs
modified:
  extensions/ds-registry.vala
  src/engine.vala
  src/sql.vala
  src/utils.vala
  src/where-clause.vala
  src/zeitgeist-daemon.vala


--
lp:~zeitgeist/zeitgeist/bluebird
https://code.launchpad.net/~zeitgeist/zeitgeist/bluebird

Your team Zeitgeist Framework Team is subscribed to branch lp:~zeitgeist/zeitgeist/bluebird.
To unsubscribe from this branch go to https://code.launchpad.net/~zeitgeist/zeitgeist/bluebird/+edit-subscription

=== modified file 'extensions/ds-registry.vala'
--- extensions/ds-registry.vala	2011-09-14 19:46:32 +0000
+++ extensions/ds-registry.vala	2011-09-15 22:15:58 +0000
@@ -195,8 +195,6 @@
                 warning ("%s", err.message);
             }
 
-            // FIXME: nothing changed, why is this here?
-            dirty = true;
             // FIXME: set up gobject timer like ->
             // gobject.timeout_add(DISK_WRITE_TIMEOUT, self._write_to_disk)
         }
@@ -217,6 +215,7 @@
                 warning ("%s", err.message);
             }
 
+            write_to_disk();
             debug ("%s, this.ref_count = %u", Log.METHOD, this.ref_count);
         }
 
@@ -274,7 +273,7 @@
                 ds.event_templates = templates;
                 ds.timestamp = Timestamp.now ();
                 ds.running = true;
-                // FIXME: Write to disk here
+                write_to_disk();
                 
                 data_source_registered (ds.to_variant ());
 
@@ -289,7 +288,7 @@
                 new_ds.running = true;
                 new_ds.timestamp = Timestamp.now ();
                 sources.insert (unique_id, new_ds);
-                // FIXME: Write to disk here
+                write_to_disk();
                 
                 data_source_registered (new_ds.to_variant ());
                 
@@ -349,10 +348,12 @@
             }
         }
 
-        private bool write_to_disk ()
+        private void write_to_disk ()
         {
-            //FIXME: Write to disk needs to be implemented
-            return true;
+            if (dirty)
+            {
+                //FIXME: Write to disk needs to be implemented
+            }
         }
     }
 

=== modified file 'src/engine.vala'
--- src/engine.vala	2011-09-14 18:37:44 +0000
+++ src/engine.vala	2011-09-15 22:15:58 +0000
@@ -106,7 +106,7 @@
                     stmt.column_int (EventViewRows.ACTOR));
                 event.origin = stmt.column_text (
                     EventViewRows.EVENT_ORIGIN_URI);
-                // FIXME: payload
+                // FIXME: load payload
                 events.insert (event_id, event);
             }
 
@@ -750,7 +750,6 @@
      */
     public void close ()
     {
-        // FIXME: unload extensions
         database.close();
     }
 

=== modified file 'src/sql.vala'
--- src/sql.vala	2011-08-23 12:58:58 +0000
+++ src/sql.vala	2011-09-15 22:15:58 +0000
@@ -56,9 +56,8 @@
         public Sqlite.Statement id_retrieval_stmt;
         public Sqlite.Statement move_handling_stmt;
 
-        // FIXME: Should this be accessible from engine.vala or not?
-        //  Probably it should, since otherwise there won't be much
-        //  functionallity left for engine.vala.
+        // The DB should be accessible from engine for statement preperations
+        //  as well as allowing extensions to add tables to it.
         public Sqlite.Database database;
 
         public ZeitgeistDatabase () throws EngineError

=== modified file 'src/utils.vala'
--- src/utils.vala	2011-09-14 19:46:32 +0000
+++ src/utils.vala	2011-09-15 22:15:58 +0000
@@ -36,7 +36,6 @@
 
         // D-Bus
         public const string DBUS_INTERFACE = "";
-        public const string SIG_EVENT = "asaasay"; // FIXME: remove this?
 
         // Required version of DB schema
         public const string CORE_SCHEMA = "core";

=== modified file 'src/where-clause.vala'
--- src/where-clause.vala	2011-08-24 23:51:38 +0000
+++ src/where-clause.vala	2011-09-15 22:15:58 +0000
@@ -174,7 +174,7 @@
             string conditions_string = string.joinv (relation_sign,
                 generic_array_to_unowned_array<string> (conditions));
             return "%s(%s)".printf (negation_sign, conditions_string);
-		}
+        }
 
         public unowned GenericArray<string> get_bind_arguments ()
         {

=== modified file 'src/zeitgeist-daemon.vala'
--- src/zeitgeist-daemon.vala	2011-09-15 17:57:10 +0000
+++ src/zeitgeist-daemon.vala	2011-09-15 22:15:58 +0000
@@ -121,7 +121,6 @@
             }
             catch (EngineError e)
             {
-                // FIXME
                 safe_exit ();
             }
 
@@ -197,11 +196,9 @@
             return event_ids;
         }
 
-        // FIXME
         public Variant delete_events (uint32[] event_ids, BusName sender)
             throws Error
         {
-            //FIXME: Why is this not called?
             TimeRange? time_range = engine.delete_events (event_ids, sender);
             if (time_range != null)
             {