← Back to team overview

zeitgeist team mailing list archive

Re: [Merge] lp:~zeitgeist/zeitgeist/bluebird-no-distinct into lp:zeitgeist

 

33	+                event_ids += event_id;

We could be more clever here, this will cause 3-6 reallocations in common cases, perhaps the array should be preallocated to `int.min(max_events, 128)`? (for non-zero max_events).
-- 
https://code.launchpad.net/~zeitgeist/zeitgeist/bluebird-no-distinct/+merge/87175
Your team Zeitgeist Framework Team is requested to review the proposed merge of lp:~zeitgeist/zeitgeist/bluebird-no-distinct into lp:zeitgeist.


References