← Back to team overview

zeitgeist team mailing list archive

Re: [Merge] lp:~zeitgeist/zeitgeist/bluebird-sig-crash into lp:zeitgeist

 

Review: Needs Fixing

156	             assert (event_variant.get_type_string () == "(" +
157	                 Utils.SIG_EVENT + ")");

Let's turn this into assert_sig as well.

161	-            assert (iter.n_children () >= 3);

Shouldn't this throw the error as well, instead of just removing it?

-- 
https://code.launchpad.net/~zeitgeist/zeitgeist/bluebird-sig-crash/+merge/74091
Your team Zeitgeist Framework Team is subscribed to branch lp:zeitgeist.


References