zeitgeist team mailing list archive

[Siegfried Gevatter <rainct@xxxxxxxxxx>]

Review: Needs Fixing

Awesome! C++ FTS ftw.

- Add COPYING.GPL3, otherwise the tarball can't be re-distributed.

- Considering sharing a get_flags_for_log_level or even set_log_level
  function between ZG and FTS?

- s/ver != DatabaseSchema.CORE_SCHEMA_VERSION)/ver < DatabaseSchema.CORE_SCHEMA_VERSION/
  What's the rationale for this? We don't know changes won't break compatibility

- Can you explain the "// Don't disconnect monitors using service names"?

I didn't really review the C++ stuff (I'm asuming you and Mikkel reviewed each other's stuff already?).
-- 
https://code.launchpad.net/~zeitgeist/zeitgeist/fts++/+merge/92022
Your team Zeitgeist Framework Team is subscribed to branch lp:zeitgeist.