← Back to team overview

zeitgeist team mailing list archive

[Merge] lp:~tdfischer/zeitgeist-explorer/latest-gi into lp:zeitgeist-explorer

 

Trever Fischer has proposed merging lp:~tdfischer/zeitgeist-explorer/latest-gi into lp:zeitgeist-explorer.

Requested reviews:
  Zeitgeist Framework Team (zeitgeist)

For more details, see:
https://code.launchpad.net/~tdfischer/zeitgeist-explorer/latest-gi/+merge/97719

Uses named parameters for GtkTreeView constructors, allowing it to run on Fedora 15.
-- 
https://code.launchpad.net/~tdfischer/zeitgeist-explorer/latest-gi/+merge/97719
Your team Zeitgeist Framework Team is requested to review the proposed merge of lp:~tdfischer/zeitgeist-explorer/latest-gi into lp:zeitgeist-explorer.
=== modified file 'zgexplorer/filtermanager.py'
--- zgexplorer/filtermanager.py	2012-03-13 20:59:11 +0000
+++ zgexplorer/filtermanager.py	2012-03-15 18:40:25 +0000
@@ -55,7 +55,7 @@
         for i in self.builtin:
             self.predefined_store.append([i, self.builtin[i][0]])
 
-        self.predefined_view = Gtk.TreeView(self.predefined_store)
+        self.predefined_view = Gtk.TreeView(model=self.predefined_store)
         self.predefined_view.connect("cursor-changed", self.on_cursor_changed)
         column_pix_name = Gtk.TreeViewColumn(_('Name'))
         self.predefined_view.append_column(column_pix_name)
@@ -86,7 +86,7 @@
 
         self.custom_store = Gtk.ListStore(int, str)
 
-        self.custom_view = Gtk.TreeView(self.custom_store)
+        self.custom_view = Gtk.TreeView(model=self.custom_store)
         self.custom_view.connect("cursor-changed", self.on_custom_cursor_changed)
 
         column_pix_name = Gtk.TreeViewColumn(_('Name'))

=== modified file 'zgexplorer/monitorviewer.py'
--- zgexplorer/monitorviewer.py	2012-03-12 20:57:29 +0000
+++ zgexplorer/monitorviewer.py	2012-03-15 18:40:25 +0000
@@ -93,7 +93,7 @@
 
         # Event Id, TimeStamp, Interpretation, Manifestation, Actor
         self.store = Gtk.ListStore( int, str, str, str, str)
-        self.treeview = Gtk.TreeView(self.store)
+        self.treeview = Gtk.TreeView(model=self.store)
         self.treeview.connect("cursor-changed", self.on_event_selected)
         self.scroll.add(self.treeview)
 

=== modified file 'zgexplorer/window.py'
--- zgexplorer/window.py	2012-03-13 20:59:11 +0000
+++ zgexplorer/window.py	2012-03-15 18:40:25 +0000
@@ -104,7 +104,7 @@
         monitor_vbox = Gtk.VBox()
         list_vbox.pack_start(monitor_vbox, True, True, 0)
         self.monitors = Gtk.ListStore(int, str, bool)
-        self.monitor_tree = Gtk.TreeView(self.monitors)
+        self.monitor_tree = Gtk.TreeView(model=self.monitors)
         self.monitor_tree.connect("cursor-changed", self.on_treeview_selected)
         self.monitor_tree.set_size_request(200, 600)
         self.monitor_tree.set_border_width(1)


Follow ups