zeitgeist team mailing list archive

[Siegfried Gevatter <rainct@xxxxxxxxxx>]

Review: Needs Fixing

Hi Trever,

First of all, thank you for working on this!

As commented on IRC, I don't really see a point for storage_state, num_events and result_type in the event deletion method. The original proposal just had time_range and event_templates.

(I'm also unconvinced that this methods performance is critical enough to warrant the complexity of duplicating the query. I think I may prefer a FindEventIds+DeleteEvents implementation, like Seif proposed.)
-- 
https://code.launchpad.net/~tdfischer/zeitgeist/timerange-deletion-api/+merge/97272
Your team Zeitgeist Framework Team is subscribed to branch lp:zeitgeist.