zeitgeist team mailing list archive

[Manish Sinha (मनीष सिन्हा) <me@xxxxxxxxxxxxxxx>]

Manish Sinha (मनीष सिन्हा) has proposed merging lp:~zeitgeist/activity-log-manager/fix-bug-1058037 into lp:ubuntu/quantal-proposed/activity-log-manager.

Requested reviews:
  Ubuntu Development Team (ubuntu-dev)
Related bugs:
  Bug #1050620 in Activity Log Manager: "activity-log-manager crashed with SIGSEGV in g_action_muxer_insert()"
  https://bugs.launchpad.net/activity-log-manager/+bug/1050620
  Bug #1058037 in Activity Log Manager: "Activity Log Manager crashes with GLib-GIO-CRITICAL **: g_application_list_actions: assertion `application->priv->is_registered' failed"
  https://bugs.launchpad.net/activity-log-manager/+bug/1058037

For more details, see:
https://code.launchpad.net/~zeitgeist/activity-log-manager/fix-bug-1058037/+merge/159896

Fixes bugs LP: #1058037 and LP: #1050620 caused by wrong usage of GtkApplication
-- 
https://code.launchpad.net/~zeitgeist/activity-log-manager/fix-bug-1058037/+merge/159896
Your team Zeitgeist Framework Team is subscribed to branch lp:~zeitgeist/activity-log-manager/fix-bug-1058037.

=== modified file 'debian/changelog'
--- debian/changelog	2012-11-26 17:05:56 +0000
+++ debian/changelog	2013-04-19 21:34:24 +0000
@@ -1,3 +1,13 @@
+activity-log-manager (0.9.4-0ubuntu4.3) quantal-proposed; urgency=low
+
+  * 07_fix_gtkapplication.patch:
+    - Activity Log Manager crashes with GLib-GIO-CRITICAL **: 
+      g_application_list_actions: assertion 
+      `application->priv->is_registered' failed.
+      (LP: #1058037) (LP: #1050620)
+
+ -- Manish Sinha <manishsinha@xxxxxxxxxx>  Fri, 19 Apr 2013 14:26:04 -0700
+
 activity-log-manager (0.9.4-0ubuntu4.2) quantal-proposed; urgency=low
 
   * 07_fix_userdirs.patch:

=== added file 'debian/patches/08_fix_gtkapplication.patch'
--- debian/patches/08_fix_gtkapplication.patch	1970-01-01 00:00:00 +0000
+++ debian/patches/08_fix_gtkapplication.patch	2013-04-19 21:34:24 +0000
@@ -0,0 +1,52 @@
+=== modified file 'src/alm.vala'
+--- activity-log-manager-0.9.4.orig/src/alm.vala 2012-03-01 21:25:48 +0000
++++ activity-log-manager-0.9.4/src/alm.vala 2013-04-19 13:57:45 -0700
+@@ -23,6 +23,23 @@ using Gtk;
+ 
+ 
+ namespace Alm {
++	public class App : Gtk.Application
++	{
++		public App()
++		{
++			Object(application_id: "org.zeitgeist.Alm", flags: ApplicationFlags.FLAGS_NONE);
++		}
++		public override void activate()
++		{
++			var window = new Main();
++			add_window(window);
++		}
++		public static void main(string[] args)
++		{
++			var app = new App();
++			app.run();
++		}
++	}
+ 	public class Main : Gtk.Window 
+ 	{
+ 		public Main ()
+@@ -31,23 +48,6 @@ namespace Alm {
+ 			var widget = new ActivityLogManager();
+ 			this.add(widget);
+ 			this.show_all();
+-			this.destroy.connect(on_destroy);
+-		}
+-		[CCode (instance_pos = -1)]
+-		public void on_destroy (Widget window) 
+-		{
+-			Gtk.main_quit();
+-		}
+-		static int main (string[] args) 
+-		{
+-			Gtk.init (ref args);
+-			var alm = new Gtk.Application ("org.zeitgeist.Alm", 
+-										ApplicationFlags.FLAGS_NONE);
+-			var window = new Main ();
+-			alm.add_window (window);
+-			
+-			Gtk.main ();
+-			return 0;
+ 		}
+ 	}
+ }
+

=== modified file 'debian/patches/series'
--- debian/patches/series	2012-11-26 17:05:56 +0000
+++ debian/patches/series	2013-04-19 21:34:24 +0000
@@ -5,3 +5,4 @@
 05_add_missing_configvapi.patch
 06_add_unity_dash_privacy.patch
 07_fix_userdirs.patch
+08_fix_gtkapplication.patch