zeitgeist team mailing list archive

[Jeremy Bicha <jbicha@xxxxxxxxxx>]

Jeremy Bicha has proposed merging lp:~jbicha/activity-log-manager/turn-off-recently-used-too into lp:activity-log-manager.

Requested reviews:
  Activity Log Manager (activity-log-manager)
Related bugs:
  Bug #992338 in Activity Log Manager: "Privacy settings don't affect Gnome recently-used list."
  https://bugs.launchpad.net/activity-log-manager/+bug/992338

For more details, see:
https://code.launchpad.net/~jbicha/activity-log-manager/turn-off-recently-used-too/+merge/173383

When a user turns off Recording File & Application Usage, both Zeitgeist and the GTK/GNOME recently used feature will stop adding new items to their databases.

As for the second half of the bug, it looks to me like GNOME's Privacy panel doesn't yet include an option to clear the recently used database. We could just remove the recently-used.xbel file if a user chooses to "Clear Usage Data from all time".
-- 
https://code.launchpad.net/~jbicha/activity-log-manager/turn-off-recently-used-too/+merge/173383
Your team Activity Log Manager is requested to review the proposed merge of lp:~jbicha/activity-log-manager/turn-off-recently-used-too into lp:activity-log-manager.

=== modified file 'src/unified-privacy.vala'
--- src/unified-privacy.vala	2013-07-03 08:09:42 +0000
+++ src/unified-privacy.vala	2013-07-07 21:25:30 +0000
@@ -66,8 +66,12 @@
 		
 		private Gtk.Menu exception_menu;
 		
+		private GLib.Settings privacy_settings;
+
 		public PrivacyWidget (Blacklist blacklist_interface) {
 			GLib.Object (orientation: Orientation.VERTICAL, spacing:10);
+
+			privacy_settings = new GLib.Settings ("org.gnome.desktop.privacy");
 			
 			this.blacklist = blacklist_interface;
 			//File/Folder stuffs
@@ -188,6 +192,7 @@
 				var recording = !blacklist.get_incognito();
 				if (this.record_button.active != recording) {
 					blacklist.set_incognito(recording);
+				privacy_settings.set_boolean("remember-recent-files", record_button.active);
 				}
 			});