zeya team mailing list archive

[Phil Sung <philbert@xxxxxxxxx>]

Hi Amit,

(Happy new year! I apologize for the delay in responding. Various
things have been keeping me busy.)

On Thu, Dec 31, 2009 at 04:47, Amit Saha <lists.amitsaha@xxxxxxxxx> wrote:
> Amit Saha wrote:
>> Pls. find attched the m3u.py file implementing the m3u backend and patches
>> to existing files.

Thanks! In general I think everything basically looks sound. A few comments:

1. Please move extract_metadata and album_name_from_path to
backends.py so both the dir and m3u backends can take advantage of a
single implementation.

2. If you use os.path.expanduser (and optionally, also
os.path.abspath), then you can remove the requirement that the user
specify an absolute path to the playlist.

>> Going ahead, I will probably add support for PLS files using the same
>> backend and choose the backend class depending upon the playlist file
>> extension.

That sounds good to me.

Cheers,
Phil