zim-wiki team mailing list archive

[Jaap Karssenberg <jaap.karssenberg@xxxxxxxxx>]

Applied patch in development tree.

Thanks,

Jaap



On Wed, Jul 2, 2014 at 5:49 PM, Thomas Harning Jr. <harningt@xxxxxxxxx>
wrote:

> Tags are great when your page 'basename' is descriptive, however,
> especially in the case of the Journal namespacing, you end up with
> duplicate numbers, ex:
> I have a tag on June 4 and July 4th, I see 04 (at least) twice in the
> tag tree... [1]
>
> This sort of issue appears in both with and without the sort pages by
> tags options set.
>
> Some sort of tree structure should remain in the tag view, especially
> for the Journal case, but in many others I name the final note with
> the understanding that it's identity is strongly tied to at least most
> of its hierarchy. Perhaps the view could display the colon-delimited
> format for names as an option, or perhaps take the existing tree view,
> but strip it down so that pages w/ matching tags are visible, as well
> as [perhaps greyed out / unselectable] the super-pages leading to
> those matching pages are visible.
>
> I took a look at the code on how the views are constructed and, while
> versed in python and programming in general, I realized that I have
> very little idea what I am doing in that area.
> I took a stab and came up with this basic patch to get the full path
> in the page for tag pages... no configuration or 'fancy' path
> handling, but it seems to work okay.
>
> diff --git a/zim/plugins/tags.py b/zim/plugins/tags.py.py
> index 7ff0d2e..ed0c375 100644
> --- a/zim/plugins/tags.py
> +++ b/zim/plugins/tags.py
> @@ -561,6 +561,8 @@ class TagsPageTreeStore(DuplicatePageTreeStore):
>                                 #~ else:
>                                         #~ return
> str(self.index.n_list_tagged_pages(tag))
>                 else:
> +                       if column == NAME_COL:
> +                               return iter.indexpath.name
>                         return PageTreeStore.on_get_value(self, iter,
> column)
>
>
> 1: I said at least because I just noticed a bug:
> It see... er saw 3 04 references, 1st was for June 4th, 2nd and 3rd
> were for July 4th, but clicking the 3rd did nothing UI-wise.
> Looks like there might be something going on there, but cannot
> reproduce anymore after applying/undoing the "sort pages by tags" to
> that, nor in a simpler notebook case.
>
> --
> Thomas Harning Jr. (http://about.me/harningt)
>
> _______________________________________________
> Mailing list: https://launchpad.net/~zim-wiki
> Post to     : zim-wiki@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~zim-wiki
> More help   : https://help.launchpad.net/ListHelp
>