← Back to team overview

zorba-coders team mailing list archive

Re: [Merge] lp:~zorba-coders/zorba/identifiers into lp:zorba

 

Review: Needs Fixing

Minor comments from Ghislain;

node-reference.xq
line 41: do -> does
line 42: in that, a generated identifier has never been generated before. -> in that two nodes with different identifies will never have identical identifiers.
("generate" is an implementation detail).
Same for lines 73/74.
line 96: missing newline

nodes.h
line 366: node-by-identifier -> node-by-reference?
-- 
https://code.launchpad.net/~zorba-coders/zorba/identifiers/+merge/78383
Your team Zorba Coders is subscribed to branch lp:zorba.


References