← Back to team overview

zorba-coders team mailing list archive

Re: [Merge] lp:~zorba-coders/zorba/identifiers into lp:zorba

 

> >
> > The function returns the empty sequence if the node
> > that is referenced was deleted.
> > =>
> > The function returns the empty sequence if the node
> > that is referenced does not exist (e.g. because it was deleted or the
> > temporary node is not available anymore)
> >
> 

Done.

> I wouldn't add the "(e.g. because ....)" part. After all, a temporary node
> becomes not available by being deleted. So, the phrase does not really add any
> additional info.
> 
> > zerr::ZAPI0028
> > =>
> > zerr:ZAPI0028
> >
> > Can any of the functions return ZAPI0029? If so, it's not documented. Same
> for
> > ZAPI0030.
> >
> 
> I am not sure, but these 2 errors are being used just for internal sanity
> checks. If so, they should be removed from the diagnostics list (use
> ZORBA_ASSERT() instead).

They cannot be raised by the functions in this module. However they can be raised when some of the simple_store methods are called directly, like i do in my pul module. 
An example could be a PUL which requires to insert a node with an identity which is already assigned to another node. (Either the same PUL/operation is applied twice or the user is using crafting ids). In those function these errors are either catched and wrapped into other errors or thrown.


-- 
https://code.launchpad.net/~zorba-coders/zorba/identifiers/+merge/78383
Your team Zorba Coders is subscribed to branch lp:zorba.


Follow ups

References