← Back to team overview

zorba-coders team mailing list archive

Re: [Merge] lp:~zorba-coders/zorba/updrevalidate into lp:zorba

 

> Why variable numUpdates in PULImpl::mergeUpdateList is declared, assigned but
> never read?

Good question :) The easy answer is to just remove it. But I think it can actually be used to replace the myList.size() in the 2 for loops at lines 1289 and 1308. Even though new entries can be added in myList during each iteration of the outer for-loop, I think that during those 2 inner for-loops it is ok to search myList only up to numUpdates. Do you agree?

-- 
https://code.launchpad.net/~zorba-coders/zorba/updrevalidate/+merge/79331
Your team Zorba Coders is subscribed to branch lp:zorba.


Follow ups

References