zorba-coders team mailing list archive
-
zorba-coders team
-
Mailing list archive
-
Message #01325
Re: [Merge] lp:~ceejatec/zorba/feature-module-installation into lp:zorba
Review: Needs Information
Looks good in general. Only tried compiling so far but didn't install. I would suggest that at least somebody with Windows also tries it.
Minor comments:
- theURIPath (good name?); theXQPath?
- setLibPath or setLibPaths in the public api?
- should we really remove -module-path from zorbacmd but keep it in the public sctx (backwards incompatible?)
- same for ZORBA_MODULES_INSTALL_DIR
Will you add documentation & change log before merging?
--
https://code.launchpad.net/~ceejatec/zorba/feature-module-installation/+merge/80040
Your team Zorba Coders is subscribed to branch lp:zorba.
References