zorba-coders team mailing list archive

[Chris Hillery <chillery+launchpad@xxxxxxxxx>]

1. It looks like your editor is still randomly changing whitespace on certain lines, resulting in extraneous diffs... I hope you can figure out what's causing that and disable it.


2. In testdriver_mt, would it be possible to create the XML results on-disk as you go, rather than collecting the results in a huge in-memory stringstream?


3. One problem in Submit_xqts.cmake: you have

  set (testfile "${builddir}/Testing/Test.xml")
  if(testfile)
     ...

That will always be true. I think you meant

  if (EXISTS "${testfile}")


4. I also don't like that you had to duplicate the execute_process() call to Zorba. Couldn't you just set(testfile) in both branches of the "if (testdriver_mt)", and then move the execute_process() call after the endif()? Since you have a FATAL_ERROR if the Test.xml file isn't found, you don't have to worry about testfile being set to something bogus.

-- 
https://code.launchpad.net/~zorba-coders/zorba/conformance_reports_generation/+merge/80297
Your team Zorba Coders is subscribed to branch lp:zorba.