zorba-coders team mailing list archive

[Matthias Brantner <matthias.brantner@xxxxxxxxxx>]

> Sorry, I still don't understand why you added the zorba/config.h include. I
> was able to fix the included test case locally by doing only the change in
> strings_impl.cpp; it doesn't seem like the dict_XX_cpp.xq change is related at
> all. And I still think that adding that #include is a bad idea unless it's
> vitally necessary, because Zorba already has far too many header dependencies.
Chris, I agree with Daniel that the include is necessary. For example, dict_en.cpp
uses guards such as ZORBA_NO_FULL_TEXT to enable or disabled certain errors. Those
guards are only available if config.h is included.
-- 
https://code.launchpad.net/~danielturcanu/zorba/mytrunk/+merge/79165
Your team Zorba Coders is subscribed to branch lp:zorba.