zorba-coders team mailing list archive

Thread
Date

Re: [Merge] lp:~danielturcanu/zorba/mytrunk into lp:zorba

To: Daniel Turcanu <danielturcanu@xxxxxxxxx>
From: Chris Hillery <chillery+launchpad@xxxxxxxxx>
Date: Wed, 23 Nov 2011 02:41:23 -0000
In-reply-to: <20111012184026.11915.90388.launchpad@ackee.canonical.com>
Reply-to: mp+79165@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Approve

I still don't understand the #include situation. Clearly dict_en.cpp is not *yet* using ZORBA_NO_FULL_TEXT or else it wouldn't compile. What I'm guessing is that there is some other change coming from somewhere else which depends on having that #include. If so, IMHO then the #include should be added in conjunction with that change, not this one.

Still, assuming for the moment that the #include will be necessary *someday*, I'm approving this change 'cause frankly this proposal has been beaten to death already...
-- 
https://code.launchpad.net/~danielturcanu/zorba/mytrunk/+merge/79165
Your team Zorba Coders is subscribed to branch lp:zorba.

References

[Merge] lp:~danielturcanu/zorba/mytrunk into lp:zorba
From: Daniel Turcanu, 2011-10-12