zorba-coders team mailing list archive

[Markos Zaharioudakis <markos_za@xxxxxxxxx>]

> I see though some things in:
> src/compiler/expression/expr.cpp
> 
> for the debugger expression in my debugger branch I have now:
> 
> 
> void debugger_expr::compute_scripting_kind()
> {
>   theScriptingKind = theExpr->get_scripting_detail();
> }
> 
Ok, I will add this.

> zorba::expr_script_kind_t
> debugger_expr::get_scripting_kind()
> {
>   return (zorba::expr_script_kind_t)theScriptingKind;
> }

This is wrong. theScriptingKind will, in general, be an ORing of the expr_script_kind_t enum values. You should probably have 2 separate bool params - isSequential and isUpdating - to the EvalIterator constructor, like this:

argv.push_back(new EvalIterator(sctx,
                                  qloc,
                                  argvEvalIter,
                                  varnames,
                                  vartypes,
                                  v.is_sequential(),
                                  v.is_updating(),
                                  localBindings));

-- 
https://code.launchpad.net/~zorba-coders/zorba/markos-scratch/+merge/84652
Your team Zorba Coders is subscribed to branch lp:zorba.