← Back to team overview

zorba-coders team mailing list archive

Re: [Merge] lp:~zorba-coders/zorba/ItemFactory into lp:zorba

 

Review: Needs Fixing

The commit looks good to me. However, could you please put an item int he ChangeLog that mentions the api extension?

Also, for consistency and performance, the results of the Unmarshaller calls in createComment/PiNode should be "zstring const&".
-- 
https://code.launchpad.net/~zorba-coders/zorba/ItemFactory/+merge/86125
Your team Zorba Coders is subscribed to branch lp:zorba.


References