← Back to team overview

zorba-coders team mailing list archive

Re: [Merge] lp:~zorba-coders/zorba/debugger_client into lp:zorba

 

Review: Approve

I reviewed CMakeConfiguration.txt, bin/CMakeLists.txt, bin/debugger/config.h.cmake.

Looks good to me. I was only thinking if it would be a good idea to remove the option ZORBA_WITH_DEBUGGER_CLIENT (generating the debugger client if debugging is switched on). The less options to better.
-- 
https://code.launchpad.net/~zorba-coders/zorba/debugger_client/+merge/86305
Your team Zorba Coders is subscribed to branch lp:zorba.


References