zorba-coders team mailing list archive

Thread
Date

Re: [Merge] lp:~danielturcanu/zorba/link1_fix into lp:zorba

To: Daniel Turcanu <danielturcanu@xxxxxxxxx>
From: Chris Hillery <chillery+launchpad@xxxxxxxxx>
Date: Wed, 28 Dec 2011 21:58:27 -0000
In-reply-to: <20111228090626.30837.92842.launchpad@ackee.canonical.com>
Reply-to: mp+86994@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Fixing

- Please put a very prominent comment around the SKIP_TEST block identifying why the test is skipped and listing the bug number.

- Likewise, please add comment referring to the bug number next to the commented-out EXPECTED_FAILURE() for the link1 test.

- If the external1/external2 tests are working now, you should just remove the EXPECTED_FAILURE() lines rather than commenting them out.

FYI, for relatively trivial changes like this, I would have just made the corrections myself, but since the branch is owned by ~danielturcanu I couldn't do that...
-- 
https://code.launchpad.net/~danielturcanu/zorba/link1_fix/+merge/86994
Your team Zorba Coders is subscribed to branch lp:zorba.

References

[Merge] lp:~danielturcanu/zorba/link1_fix into lp:zorba
From: Daniel Turcanu, 2011-12-28