zorba-coders team mailing list archive
-
zorba-coders team
-
Mailing list archive
-
Message #03237
[Merge] lp:~zorba-coders/zorba/bug-885512 into lp:zorba
Daniel Turcanu has proposed merging lp:~zorba-coders/zorba/bug-885512 into lp:zorba.
Requested reviews:
Zorba Coders (zorba-coders)
Related bugs:
Bug #885512 in Zorba: "Windows 8 Developer Preview bugs"
https://bugs.launchpad.net/zorba/+bug/885512
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug-885512/+merge/87459
The bug was fixed in november. Paul did a fix, and the user had to do a clean rebuild.
The bug was not related to Windows 8.
--
https://code.launchpad.net/~zorba-coders/zorba/bug-885512/+merge/87459
Your team Zorba Coders is requested to review the proposed merge of lp:~zorba-coders/zorba/bug-885512 into lp:zorba.
=== modified file 'src/util/string_util.h'
--- src/util/string_util.h 2011-10-11 17:59:20 +0000
+++ src/util/string_util.h 2012-01-04 11:24:25 +0000
@@ -28,6 +28,12 @@
#include "cxx_util.h"
#include "stl_util.h"
+#ifdef WIN32
+// Windows annoyingly defines these as macros.
+#undef max
+#undef min
+#endif /* WIN32 */
+
namespace zorba {
namespace ztd {
Follow ups
-
[Merge] lp:~zorba-coders/zorba/bug-885512 into lp:zorba
From: noreply, 2012-01-04
-
[Merge] lp:~zorba-coders/zorba/bug-885512 into lp:zorba
From: Zorba Build Bot, 2012-01-04
-
[Merge] lp:~zorba-coders/zorba/bug-885512 into lp:zorba
From: Zorba Build Bot, 2012-01-04
-
[Merge] lp:~zorba-coders/zorba/bug-885512 into lp:zorba
From: Matthias Brantner, 2012-01-04
-
Re: [Merge] lp:~zorba-coders/zorba/bug-885512 into lp:zorba
From: Matthias Brantner, 2012-01-04
-
Re: [Merge] lp:~zorba-coders/zorba/bug-885512 into lp:zorba
From: Daniel Turcanu, 2012-01-04
-
Re: [Merge] lp:~zorba-coders/zorba/bug-885512 into lp:zorba
From: Paul J. Lucas, 2012-01-04
-
[Merge] lp:~zorba-coders/zorba/bug-885512 into lp:zorba
From: Zorba Build Bot, 2012-01-04
-
Re: [Merge] lp:~zorba-coders/zorba/bug-885512 into lp:zorba
From: Zorba Build Bot, 2012-01-04
-
[Merge] lp:~zorba-coders/zorba/bug-885512 into lp:zorba
From: Zorba Build Bot, 2012-01-04
-
[Merge] lp:~zorba-coders/zorba/bug-885512 into lp:zorba
From: Zorba Build Bot, 2012-01-04
-
[Merge] lp:~zorba-coders/zorba/bug-885512 into lp:zorba
From: Daniel Turcanu, 2012-01-04