zorba-coders team mailing list archive
-
zorba-coders team
-
Mailing list archive
-
Message #03286
Re: [Merge] lp:~zorba-coders/zorba/get-namespace-bindings into lp:zorba
> Regarding vector vs. map, after thinking about it a bit, I agree with you that
> map<> would be at least a bit better user experience. However,
> ItemFactory::createElementNode() takes a vector<pair<>> already, and that
> can't be changed. I think probably it's best that getNamespaceBindings() be
> consistent with that API.
Fair enough.
>
> In fact, probably createElementNode() should be changed to use the same
> typedef as getNamespaceBindings(). Should I move the typedef for NsBindings
> into store_consts.h?
No, I don't think so. Because the internal NsBindings uses zstring (not zorba::String)
--
https://code.launchpad.net/~zorba-coders/zorba/get-namespace-bindings/+merge/87187
Your team Zorba Coders is subscribed to branch lp:zorba.
Follow ups
References