← Back to team overview

zorba-coders team mailing list archive

Re: [Merge] lp:~zorba-coders/zorba/feature-json_parser into lp:zorba

 

> No, the point is *not* to fix this issues ASAP.  The feature is not a high-
> priority feature, so there's no reason to do this ASAP.  My *only* point was
> why you added EXPECTED_FAILURE lines to the CMakeLists.txt file -- that's it.
> 
> But it's moot now since I've removed all the new EXPECTED_FAILURES that you've
> added.  They're of no use to me.  Now when I run the test suite and it reports
> 100% tests passed, I can be confident that I've fixed all the bugs and not
> have an errant EXPECTED_FAILURE in there.
> 
> In the future, please don't add EXPECTED_FAILURE lines to code on a *branch*
> -- thanks.
My 2 cents: no matter what the brief description of the "ctest -R SOME_TEST" shows, one should *always* check out the details inside the ctest logs.

http://en.wikipedia.org/wiki/The_Devil_is_in_the_details

-- 
https://code.launchpad.net/~zorba-coders/zorba/feature-json_parser/+merge/89616
Your team Zorba Coders is subscribed to branch lp:zorba.


References