zorba-coders team mailing list archive

[Ghislain Fourny <ghislain.fourny@xxxxxxxxxx>]

Ghislain Fourny has proposed merging lp:~zorba-coders/zorba/virtual-destructors into lp:zorba.

Requested reviews:
  Till Westmann (tillw)
  David Graf (davidagraf)

For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/virtual-destructors/+merge/100979

Making destructors virtual for several classes that have virtual functions.
-- 
https://code.launchpad.net/~zorba-coders/zorba/virtual-destructors/+merge/100979
Your team Zorba Coders is subscribed to branch lp:zorba.

=== modified file 'include/zorba/audit.h'
--- include/zorba/audit.h	2012-03-28 05:19:57 +0000
+++ include/zorba/audit.h	2012-04-05 14:38:22 +0000
@@ -80,6 +80,8 @@
     virtual const Property* getDynamicProperty(const String&) const = 0;
 
     virtual std::ostream& write(std::ostream&) const = 0;
+    
+    virtual ~Configuration() {}
   };
 
   class ZORBA_DLL_PUBLIC Record {
@@ -109,6 +111,8 @@
     virtual const Record* at(size_t) const = 0;
 
     virtual std::ostream& write(std::ostream&) const = 0;
+    
+    virtual ~Event() {}
   };
 
   class ZORBA_DLL_PUBLIC Provider {

=== modified file 'src/api/auditimpl.h'
--- src/api/auditimpl.h	2012-03-28 05:19:57 +0000
+++ src/api/auditimpl.h	2012-04-05 14:38:22 +0000
@@ -142,6 +142,8 @@
     friend class EventImpl;
 
     RecordImpl(EventImpl* event) : m_event(event) {}
+    virtual ~RecordImpl() {}
+    
     EventImpl* m_event;
     std::vector<ObservationImpl> m_parameters;
   };