zorba-coders team mailing list archive

[Till Westmann <till.westmann@xxxxxxxxxx>]

Review: Approve

It would be nice to have 2 comments explaining 
1) the modification of the parameter in simple_index_value.cpp:380 and 674 and 
2) the role of key2 in Store::populateValueIndex.

It would also be nice to use the typedef here:

=== modified file 'src/store/naive/simple_pul.cpp'
--- src/store/naive/simple_pul.cpp	2012-04-27 19:58:40 +0000
+++ src/store/naive/simple_pul.cpp	2012-04-27 20:03:20 +0000
@@ -1463,8 +1463,8 @@
 {
   csize numRoots = rootNodes.size();
 
-  std::vector<CollectionPul*>::const_iterator collIte = theCollectionPuls.begin();
-  std::vector<CollectionPul*>::const_iterator collEnd = theCollectionPuls.end();
+  CollectionPuls::const_iterator collIte = theCollectionPuls.begin();
+  CollectionPuls::const_iterator collEnd = theCollectionPuls.end();
 
   for (; collIte != collEnd; ++collIte)
   {

-- 
https://code.launchpad.net/~zorba-coders/zorba/bug-966706/+merge/103835
Your team Zorba Coders is subscribed to branch lp:zorba.