zorba-coders team mailing list archive

[Chris Hillery <chillery+launchpad@xxxxxxxxx>]

Review: Needs Information

1. Don't you have one too many ../ when computing _JAVA_HOME from _JAVA_BIN_LOC ? On my Ubuntu 11.10, at least, java is in /usr/lib/jvm/java-6-sun/jre/bin/java, and JAVA_HOME should be /usr/lib/jvm/java-6-sun I believe.

2. Also, FYI, a variable in CMake is considered FALSE if its value ends with -NOTFOUND. So you could simplify your IF() to just

  IF (_JAVA_BIN_LOC)

3. Minor typo: "FIndJNI.cmake".
-- 
https://code.launchpad.net/~davidagraf/zorba/util-jvm-module-bug-989490/+merge/110275
Your team Zorba Coders is subscribed to branch lp:zorba/util-jvm-module.