zorba-coders team mailing list archive

Thread
Date

Re: [Merge] lp:~zorba-coders/zorba/jsoniq into lp:zorba

To: mp+92171@xxxxxxxxxxxxxxxxxx
From: Chris Hillery <chillery+launchpad@xxxxxxxxx>
Date: Thu, 21 Jun 2012 07:24:18 -0000
In-reply-to: <20120209004645.11731.35953.launchpad@ackee.canonical.com>
Reply-to: mp+92171@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Information

I've reviewed the serialization changes. One tiny issue: I think in jsoniq_emitter::emit_end(), you should call emit_end() on either theXMLEmitter or theJSONEmitter depending on theEmitterState. I know that right now, neither the XML nor the JSON emitters actually do anything in emit_end(), but if they ever need to do something in the future, this will be a bug.
-- 
https://code.launchpad.net/~zorba-coders/zorba/jsoniq/+merge/92171
Your team Zorba Coders is requested to review the proposed merge of lp:~zorba-coders/zorba/jsoniq into lp:zorba.

References

[Merge] lp:zorba/3.0 into lp:zorba
From: Matthias Brantner, 2012-02-09