← Back to team overview

zorba-coders team mailing list archive

Re: [Merge] lp:~zorba-coders/zorba/jsoniq into lp:zorba

 

Review: Needs Fixing

Unfortunately, the branch doesn't build on my 32bit Ubuntu 11.04.

- patch for first problem

=== modified file 'src/functions/func_jsoniq_functions_impl.h'
--- src/functions/func_jsoniq_functions_impl.h	2012-03-19 12:08:17 +0000
+++ src/functions/func_jsoniq_functions_impl.h	2012-06-25 21:25:49 +0000
@@ -47,7 +47,7 @@
 
   }
 
-  short getScriptingKind() const { return UPDATING_EXPR; }
+  unsigned short getScriptingKind() const { return UPDATING_EXPR; }

- second problem

/home/mbrantner/zorba/jsandbox/src/runtime/json/jsoniq_functions_impl.cpp:542:1: error: ‘TYPE_JSONObjectInsertIterator’ is not a member of ‘zorba::serialization’

if I delete this line, I get similar errors as follows:

/home/mbrantner/zorba/jsandbox/src/runtime/json/json_constructors.cpp:37:1: error: ‘TYPE_JSONObjectIterator’ is not a member of ‘zorba::serialization’
/home/mbrantner/zorba/jsandbox/src/runtime/json/json_constructors.cpp:39:1: error: ‘TYPE_JSONArrayIterator’ is not a member of ‘zorba::serialization’
/home/mbrantner/zorba/jsandbox/src/runtime/json/json_constructors.cpp:41:1: error: ‘TYPE_JSONDirectObjectIterator’ is not a member of ‘zorba::serialization’
-- 
https://code.launchpad.net/~zorba-coders/zorba/jsoniq/+merge/92171
Your team Zorba Coders is requested to review the proposed merge of lp:~zorba-coders/zorba/jsoniq into lp:zorba.


Follow ups

References