zorba-coders team mailing list archive

Thread
Date

Re: [Merge] lp:~zorba-coders/zorba/bug1023120-schemaImport into lp:zorba

To: mp+114712@xxxxxxxxxxxxxxxxxx
From: Chris Hillery <chillery+launchpad@xxxxxxxxx>
Date: Thu, 12 Jul 2012 22:32:28 -0000
In-reply-to: <20120712193417.9444.34832.launchpad@ackee.canonical.com>
Reply-to: mp+114712@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Fixing

Interesting! However, XMLString::transcode() returns a memory buffer that the caller must free by calling XMLString::release(), so I believe this change introduces a memory leak (unless InputSource will free them, which I don't think it does). I'm actually not 100% sure how to solve this - I guess IstreamInputSource could free them in its destructor, if it can tell that it needs to do so?
-- 
https://code.launchpad.net/~zorba-coders/zorba/bug1023120-schemaImport/+merge/114712
Your team Zorba Coders is subscribed to branch lp:zorba.

References

[Merge] lp:~zorba-coders/zorba/bug1023120-schemaImport into lp:zorba
From: Cezar Andrei, 2012-07-12