zorba-coders team mailing list archive

[Matthias Brantner <matthias.brantner@xxxxxxxxxx>]

Review: Needs Fixing

I have added a new XQuery module (http://www.zorba-xquery.com/modules/item) which currently provides one function x:allocated-size. The function invokes Item::alloc_size.

Review comments

- The function Item::alloc_size should be exposed in the external C++ api.
- The function alloc_size should also be implemented for JSONiq items.
- In file included from /home/mbrantner/zorba/sandbox/src/unit_tests/test_mem_sizeof.cpp:21:0:
/home/mbrantner/zorba/sandbox/src/util/mem_sizeof.h:177:58: warning: all member functions in class ‘zorba::ztd::has_alloc_size<T>’ are private
- returns zero for integer:
  import module namespace x = "http://www.zorba-xquery.com/modules/item";;

  x:allocated-size(1)


-- 
https://code.launchpad.net/~zorba-coders/zorba/feature-mem_size/+merge/114764
Your team Zorba Coders is subscribed to branch lp:zorba.