zorba-coders team mailing list archive

[Chris Hillery <chillery+launchpad@xxxxxxxxx>]

Chris Hillery has proposed merging lp:~zorba-coders/zorba/bug-1027142-process-leak into lp:zorba/process-module.

Requested reviews:
  Zorba Coders (zorba-coders)
Related bugs:
  Bug #1027142 in Zorba: "process:exec memory leak"
  https://bugs.launchpad.net/zorba/+bug/1027142

For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug-1027142-process-leak/+merge/116102
-- 
https://code.launchpad.net/~zorba-coders/zorba/bug-1027142-process-leak/+merge/116102
Your team Zorba Coders is requested to review the proposed merge of lp:~zorba-coders/zorba/bug-1027142-process-leak into lp:zorba/process-module.

=== modified file 'src/com/zorba-xquery/www/modules/process.xq.src/process.cpp'
--- src/com/zorba-xquery/www/modules/process.xq.src/process.cpp	2012-01-11 18:21:38 +0000
+++ src/com/zorba-xquery/www/modules/process.xq.src/process.cpp	2012-07-21 01:14:19 +0000
@@ -525,6 +525,15 @@
 
 /******************************************************************************
  *****************************************************************************/
+ProcessModule::~ProcessModule()
+{
+  for (FuncMap_t::const_iterator lIter = theFunctions.begin();
+       lIter != theFunctions.end(); ++lIter) {
+    delete lIter->second;
+  }
+  theFunctions.clear();
+}
+
 zorba::ExternalFunction*
 ProcessModule::getExternalFunction(const zorba::String& aLocalname)
 {

=== modified file 'src/com/zorba-xquery/www/modules/process.xq.src/process.h'
--- src/com/zorba-xquery/www/modules/process.xq.src/process.h	2011-06-09 11:42:43 +0000
+++ src/com/zorba-xquery/www/modules/process.xq.src/process.h	2012-07-21 01:14:19 +0000
@@ -48,7 +48,7 @@
   FuncMap_t theFunctions;
 
 public:
-  virtual ~ProcessModule() {}
+  virtual ~ProcessModule();
 
   virtual zorba::String getURI() const
   { return "http://www.zorba-xquery.com/modules/process";; }