← Back to team overview

zorba-coders team mailing list archive

[Merge] lp:~davidagraf/zorba/virtual_destr_auditing into lp:zorba

 

David Graf has proposed merging lp:~davidagraf/zorba/virtual_destr_auditing into lp:zorba.

Requested reviews:
  Till Westmann (tillw)
  David Graf (davidagraf)

For more details, see:
https://code.launchpad.net/~davidagraf/zorba/virtual_destr_auditing/+merge/118584

remove clang warnings in auditing code
-- 
https://code.launchpad.net/~davidagraf/zorba/virtual_destr_auditing/+merge/118584
Your team Zorba Coders is subscribed to branch lp:zorba.
=== modified file 'include/zorba/audit.h'
--- include/zorba/audit.h	2012-07-24 08:48:48 +0000
+++ include/zorba/audit.h	2012-08-07 15:41:21 +0000
@@ -62,6 +62,8 @@
     virtual const Property&    property()    const = 0;
     virtual const String& stringValue() const = 0;
     virtual long long          longValue()   const = 0;
+
+    virtual ~Observation() {}
   };
 
   class ZORBA_DLL_PUBLIC Configuration {
@@ -93,6 +95,8 @@
 
     virtual void add(const Property& prop, long long val)          = 0;
     virtual void add(const Property& prop, const String& val) = 0;
+
+    virtual ~Record() {}
   };
 
   class ZORBA_DLL_PUBLIC Event {
@@ -122,6 +126,8 @@
 
     virtual Event* createEvent(const Configuration*) = 0;
     virtual void   submitEvent(Event*)               = 0;
+
+    virtual ~Provider() {}
   };
 
 } /* namespace audit */


Follow ups