zorba-coders team mailing list archive
-
zorba-coders team
-
Mailing list archive
-
Message #14346
Re: [Merge] lp:~davidagraf/zorba/paging_index_probe into lp:zorba
Review: Needs Fixing
- the probe-index-point-value-skip and probe-index-range-value-skip functions in dml.xq don't declare the $skip parameters (but their documentation does)
- idml:probe-index-range-value-skip(xs:QName("data:idx-age-range-val"), 2, 3, true(), true(), true(), true())
reports
'"data:idx-age-range-val": invalid number of arguments to index operation; given 5 expected multiple of 6;'
but I'm counting 7 parameters
- the branch seems to undo some changes in the trunk (see diagnostic_en.xml)
- <value>$1: does not reference a node in collection $2.</value>
+ <value>Node reference $1 doesn't reference a node in collection $2.</value>
- It would be great if the iterator plan could mention if the iterator does skipping and/or counting. For example, ./test/apitest -i paging.xq contains the following snippet
<ProbeIndexRangeValueIterator id="0x1a2fb50">
<SingletonIterator value="xs:QName(http://www.test.com/,data,idx-age-range-val)" id="0x1a146a0"/>
<SingletonIterator value="xs:integer(7)" id="0x1a2c830"/>
<SingletonIterator value="xs:integer(2)" id="0x1a2c880"/>
<SingletonIterator value="xs:integer(3)" id="0x1a2c8d0"/>
<SingletonIterator value="xs:boolean(true)" id="0x1a2c920"/>
<SingletonIterator value="xs:boolean(true)" id="0x1a2c970"/>
<SingletonIterator value="xs:boolean(true)" id="0x1a2c9c0"/>
<SingletonIterator value="xs:boolean(true)" id="0x1a2ca10"/>
</ProbeIndexRangeValueIterator>
for
count(idml:probe-index-range-value-skip(xs:QName("data:idx-age-range-val"),
7, 2, 3, true(), true(), true(), true()))
--
https://code.launchpad.net/~davidagraf/zorba/paging_index_probe/+merge/122621
Your team Zorba Coders is subscribed to branch lp:zorba.
Follow ups
References