zorba-coders team mailing list archive

[Matthias Brantner <matthias.brantner@xxxxxxxxxx>]

> > - the probe-index-point-value-skip and probe-index-range-value-skip
> functions
> > in dml.xq don't declare the $skip parameters (but their documentation does)
> Fixed.
> >
> > - idml:probe-index-range-value-skip(xs:QName("data:idx-age-range-val"), 2,
> 3,
> > true(), true(), true(), true())
> >   reports
> >   '"data:idx-age-range-val": invalid number of arguments to index operation;
> > given 5 expected multiple of 6;'
> >   but I'm counting 7 parameters
> Fixed (was not my fault :-) ). Unfortunately, when trying to write a test for
> this, I found a bug: https://bugs.launchpad.net/zorba/+bug/1051897 Can you
> please double check if it is really a bug?
I commented on the bug.

> > - It would be great if the iterator plan could mention if the iterator does
> > skipping and/or counting. For example, ./test/apitest  -i paging.xq contains
> > the following snippet
> >
> > <ProbeIndexRangeValueIterator id="0x1a2fb50">
> >    <SingletonIterator value="xs:QName(http://www.test.com/,data,idx-age-
> range-
> > val)" id="0x1a146a0"/>
> >    <SingletonIterator value="xs:integer(7)" id="0x1a2c830"/>
> >    <SingletonIterator value="xs:integer(2)" id="0x1a2c880"/>
> >    <SingletonIterator value="xs:integer(3)" id="0x1a2c8d0"/>
> >    <SingletonIterator value="xs:boolean(true)" id="0x1a2c920"/>
> >    <SingletonIterator value="xs:boolean(true)" id="0x1a2c970"/>
> >    <SingletonIterator value="xs:boolean(true)" id="0x1a2c9c0"/>
> >    <SingletonIterator value="xs:boolean(true)" id="0x1a2ca10"/>
> >  </ProbeIndexRangeValueIterator>
> >
> > for
> >
> > count(idml:probe-index-range-value-skip(xs:QName("data:idx-age-range-val"),
> >   7, 2, 3, true(), true(), true(), true()))
> Is it ok to create a bug entry for this? Because this has to be done in the
> collection iterator too. It can be assigned to me. But I would like to get
> those merge proposals thru.
Does it take long to do this. It would be really nice and I'm afraid it will not
get done if we create a bug for it. ;-)

- Should a negative skip value be an error? If not, some documentation is missing here.

- ChangeLog entry is missing.

-- 
https://code.launchpad.net/~davidagraf/zorba/paging_index_probe/+merge/122621
Your team Zorba Coders is subscribed to branch lp:zorba.