zorba-coders team mailing list archive

[Matthias Brantner <matthias.brantner@xxxxxxxxxx>]

Review: Needs Fixing

- adjust date in the Copyright headers

- defaults are not backwards compatible (e.g. functions are not included by default )

- fetch:content($module-uri) => fetch:content($module-uri, "MODULE")

- we should mark the xqdoc:xqdoc function as deprecated (@deprecated tag)

- we are getting more an more out of sync with the original xqdoc schema. Is there a way to extend the schema?

- in end_visit(const FunctionDecl& and end_visit(const GlobalVarDecl
   it would be nice if you could do the following check at the beginning and don't change the indentation of the remaining body of the function
	if (!(theOptions & xqdoc_component_functions/variables))
	{
	  return
	}
	
	This would reduce the size of the diff significantly
	
- a collection is output as 
<xqdoc:collection>
  <xqdoc:uri>foo:bar</xqdoc:uri>
</xqdoc:collection>

But foo:bar is the QName not the URI. We should either only include the localname or separate the two components in separate elements (although the ns will always be the module's namespace).

- The following index declarations leads to an empty sources element. 

declare index foo:index
  on nodes db:collection(xs:QName("foo:bar"))
  by xs:string(./@id) as xs:string;

=> <xqdoc:index>
    <xqdoc:uri>foo:index</xqdoc:uri>
    <xqdoc:sources/>
   </xqdoc:index>

Also, there is the same problem with the uri element than for collections.
-- 
https://code.launchpad.net/~zorba-coders/zorba/xqdoc-extensions/+merge/125662
Your team Zorba Coders is subscribed to branch lp:zorba.