zorba-coders team mailing list archive

[Sorin Marian Nasoi <sorin.marian.nasoi@xxxxxxxxx>]

> Thanks for the review.
> 
> - I pushed a fix for the build.
it is not on the branch yet, right?

> - I double checked the @project tag, they all look correct. I change XQDoc to
> XQDoc Core to make it more explicit.
Sounds OK.

> - Regarding Functx.xq, it was my understanding that this would require to
> update third-party modules manually. Also functx happens to be manually
> modified already (the namespace is different). I am not convinced about this
> @project tag solution, please let me know if you would like me to drop support
> for it.
The namespace will be corrected in Zorba 3.0, there is already a merge proposal from Chris for this.
So please do not modify it, simply add support for a module that is missing the @project tag.

> - I can add a test for checking for the @project tag. Which test in
> particular? There is a module that doesn't appear in the documentation (the
> debugger one). Again it all comes down on the @project tag support. I would be
> happy to drop support for the @project tag. From my experience of building
> xquery documentation, I am not convinced at all about his usefulness.
We went back and forth with this issue for some time in the past and this was the best solution we came up with.
My 2 cents: 
-please support it in your merge proposal 'as it is now' (meaning handle the cases where the @project tag is missing, see functx module)
- as soon as you have a better replacement for the @project tag we will discuss it

> - Regarding the dependency graph, could you please put it back yourself? I was
> not able to do it myself as it was highly coupled with the old codebase.
It is NOT coupled with the old codebase at all.
Just revert all your changes in file doc/zorba/xqdoc/CMakeLists.txt as suggested.

Thanks,
Sorin
-- 
https://code.launchpad.net/~zorba-coders/zorba/new-xqdoc/+merge/127663
Your team Zorba Coders is subscribed to branch lp:zorba.