← Back to team overview

zorba-coders team mailing list archive

Re: [Merge] lp:~zorba-coders/zorba/fix_address_from_geocode_test into lp:zorba/data-cleaning-module

 

Review: Approve

The fix seems OK to me. Notice nonetheless that the regular expression '([0-9]*[ ][A-Z]*[a-z]*)*' will not match address names containing diacritics or hyphens (which should not occur for the specific coordinates given in the test, but still).
-- 
https://code.launchpad.net/~zorba-coders/zorba/fix_address_from_geocode_test/+merge/127656
Your team Zorba Coders is subscribed to branch lp:zorba/data-cleaning-module.


References