← Back to team overview

zorba-coders team mailing list archive

Re: lp:~zorba-coders/zorba/image-module-dont-pass-svg-as-binary into lp:zorba/image-module

 

On Nov 8, 2012, at 6:13 AM, David Graf <david.graf@xxxxxxxxxx> wrote:

>> - getImageFromString: const String aString, should be const String& aString,
> Done
>> - basic:convert-svg-impl should use basic:convert-svg-string
> I don't understand. Currently, convert-svg-string invokes convert-svg-impl. How should that work the other way round?
Sorry, I meant to say basic:convert-svg should use basic:convert-svg-string

>> 
>> - we might have to make sure the new module is used in Zorba (edit
>> ExternalModules.conf)
> Like this: https://code.launchpad.net/~zorba-coders/zorba/image-module-head?
Yes. This one should be merged first.

Matthias
-- 
https://code.launchpad.net/~zorba-coders/zorba/image-module-dont-pass-svg-as-binary/+merge/131829
Your team Zorba Coders is subscribed to branch lp:zorba/image-module.


Follow ups

References