← Back to team overview

zorba-coders team mailing list archive

Re: [Merge] lp:~zorba-coders/zorba/fots_driver into lp:zorba

 

Hi Sorin,

That looks very good!

I have the feeling the code for eval:assert-any-of could be simplified along the lines of:

let $results :=
  for $tmp in $expResult/*
  return <result>{
    for $r in eval:check-assertion($result,
        $tmp,
        $code,
        $errorDescription,
        $showResult)
    return <item>{$r}</item>
  } </result>
where every $result in $results satisfies $result/item
return concat("&#xA;Assert-any-of returned: ",
    string-join(util:serialize-result($results/data(item)),
    ' '))

to avoid the redundant call of eval:check-assertion.
-- 
https://code.launchpad.net/~zorba-coders/zorba/fots_driver/+merge/133988
Your team Zorba Coders is subscribed to branch lp:zorba.


References