← Back to team overview

zorba-coders team mailing list archive

Re: [Merge] lp:~paul-lucas/zorba/feature-json_strip_array into lp:zorba

 

Review: Needs Fixing

- why do we need to pop the entire stack in the destructor of the loader (shouldn't it be always empty)?
- can the huge number of catch clauses in the loader be reduced by only catching a base class without loss of semantics?
- changelog entry is missing (for the new feature and the two fixed bugs)
-- 
https://code.launchpad.net/~paul-lucas/zorba/feature-json_strip_array/+merge/136826
Your team Zorba Coders is subscribed to branch lp:zorba.


Follow ups

References